Changeset 278

Show
Ignore:
Timestamp:
03/14/08 09:22:00 (5 months ago)
Author:
muness
Message:

geof's patch to include a url to the build

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • incubator/cc_campfire_notifier/campfire_notifier.rb

    r203 r278  
    3333    clear_flag 
    3434    build_text = "Build #{build.label}" 
    35     speak(build.failed? ? "#{build_text} broken" : "#{build_text} successful") 
     35    build_text << (build.failed? ? " broken" : " successful") 
     36    build_text << "\nSee #{build.url} for details" 
     37    speak(build_text) 
    3638  end 
    3739 
  • incubator/cc_campfire_notifier/HISTORY

    r204 r278  
    33 * apr_error are also SVN errors (BUG FIX) 
    44 * doesn't spam campfire when the build loop breaks (BUG FIX) 
     5 * Include link back to build report 
  • incubator/cc_campfire_notifier/test/campfire_notifier_test.rb

    r204 r278  
    1515  it "speaks when the build is successful" do 
    1616    notifier = CampfireNotifier.new 
    17     build = stub(:label => "label", :failed? => false
    18     notifier.expects(:speak).with("Build label successful") 
     17    build = stub(:label => "label", :failed? => false, :url => "http://cc.project.com/builds/Project/label"
     18    notifier.expects(:speak).with("Build label successful\nSee http://cc.project.com/builds/Project/label for details") 
    1919    notifier.expects(:clear_flag) 
    2020    notifier.build_finished(build) 
     
    2222  it "speaks when the build fails" do 
    2323    notifier = CampfireNotifier.new 
    24     build = stub(:label => "label", :failed? => true
    25     notifier.expects(:speak).with("Build label broken") 
     24    build = stub(:label => "label", :failed? => true, :url => "http://cc.project.com/builds/Project/label"
     25    notifier.expects(:speak).with("Build label broken\nSee http://cc.project.com/builds/Project/label for details") 
    2626    notifier.expects(:clear_flag) 
    2727    notifier.build_finished(build)