Changeset 166

Timestamp:

02/12/08 17:42:29 (6 months ago)

Author:

stu

Message:

quoting options does not work

Files:

• incubator/sentinel/lib/relevance/sentinel/active_record.rb (modified) (1 diff)
• incubator/sentinel/README (modified) (1 diff)
• incubator/sentinel/test/relevance/sentinel/active_record_test.rb (modified) (1 diff)

incubator/sentinel/lib/relevance/sentinel/active_record.rb

@@ -17 +17 @@
-    result[:limit] = Integer result[:limit] if result[:limit]
-    result[:offset] = Integer result[:offset] if result[:offset]
-    result[:order] = self.connection.quote(result[:order]) if result[:order]
-    result
-  end

incubator/sentinel/README

@@ -34 +34 @@
-Warning!
-============
+Sentinel is just a thought experiment. It appears increasingly unlikely that
+there is a good way to handle escaping in general.
+
-Sentinel is not production ready. At this time it is probably broken in 
-both directions, i.e.

incubator/sentinel/test/relevance/sentinel/active_record_test.rb

@@ -27 +27 @@
-  end
-
-  it "quotes options[:order]" do
-    connection = stub(:quote => :quoted_options)
-    @sentinel.expects(:connection).returns(connection)
-    @sentinel.sanitize_find_options!(:order => :stubbed_options).should == 
-        {:order => :quoted_options}
-  end
-end
-