Changeset 10

Show
Ignore:
Timestamp:
01/04/08 16:26:21 (8 months ago)
Author:
muness
Message:

more tests, cleanup

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved

  • incubator/cc_campfire_notifier/campfire_notifier.rb

    r9 r10  
    1 require 'rubygems' 
    21require 'tinder' 
    32 
    …… 
    1110  def build_finished(build) 
    1211    build_text = "Build #{build.label}" 
    13     speak(build.failed? ? "#{build_text} broken!" : "#{build_text} successful") 
     12    speak(build.failed? ? "#{build_text} broken" : "#{build_text} successful") 
    1413  end 
    1514 
    16   def build_fixed(build, previous_build) 
     15  def build_fixed(build, previous_build=nil) 
    1716    speak("Build fixed in #{build.label}") 
    1817  end 

  • incubator/cc_campfire_notifier/test/campfire_notifier_test.rb

    r9 r10  
    1  
    2 class Project  
    3  def self.plugin(plugin) 
    4  end 
     1class Project 
     2 def self.plugin(plugin) ; end 
    53end 
     4require 'rubygems' 
    65require File.dirname(__FILE__) + '/../campfire_notifier' 
    7  
    86require 'rubygems' 
    97require 'mocha' 
    …… 
    119 
    1210describe "CampfireNotifier" do 
    13  
    14  before do 
    15    Project.stubs(:plugin) 
    16  end 
    17  
    1811 it "speaks when the build is fixed" do 
    1912   notifier = CampfireNotifier.new 
    2013   build = stub(:label => "label") 
    2114   notifier.expects(:speak).with("Build fixed in label") 
    22    notifier.build_fixed(build, nil) 
     15   notifier.build_fixed(build) 
    2316 end 
    24  
     17 it "speaks when the build is successful" do 
     18   notifier = CampfireNotifier.new 
     19   build = stub(:label => "label", :failed? => false) 
     20   notifier.expects(:speak).with("Build label successful") 
     21   notifier.build_finished(build) 
     22 end 
     23 it "speaks when the build fails" do 
     24   notifier = CampfireNotifier.new 
     25   build = stub(:label => "label", :failed? => true) 
     26   notifier.expects(:speak).with("Build label broken") 
     27   notifier.build_finished(build) 
     28 end 
    2529end